Feat(anrok): add handling discarded errors when retrying invoice #2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovrocolic
reviewed
Jul 29, 2024
lovrocolic
approved these changes
Jul 31, 2024
abdussamadbello
pushed a commit
to abdussamadbello/lago-api
that referenced
this pull request
Aug 8, 2024
…lago#2341) ## Context When retrying an invoice we want to mark all previous errors as discarded, so if the invoice succeeded these errors will not be shown ## Description - Update deleted_at for existing tax_error error_details when retrying fetch taxes for the invoice - Create new errors when retrying invoice fetching taxes failed - Serialize only error_details that are not discarded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When retrying an invoice we want to mark all previous errors as discarded, so if the invoice succeeded these errors will not be shown
Description