Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dunning): Prevent creation of payment request #2459

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Conversation

rsempe
Copy link
Collaborator

@rsempe rsempe commented Aug 22, 2024

Context

We want to be able to manually request payment of the overdue balance and send emails for reminders.

https://getlago.canny.io/feature-requests/p/send-reminders-for-overdue-invoices

Description

The goal of this PR is to return an error when trying to create a payment request with:

  • invoices having different currencies
  • invoices not ready for payment processing

@rsempe rsempe changed the title feat(dunning): Prevent creation of payment request when different currencies feat(dunning): Prevent creation of payment request Aug 22, 2024
@rsempe rsempe force-pushed the feat-dunning branch 2 times, most recently from a6e490a to 0ab2a2c Compare August 22, 2024 12:54
Copy link
Contributor

@ancorcruz ancorcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

there is a precondition missed in the comment...

@rsempe rsempe merged commit a6d8eee into main Aug 23, 2024
6 checks passed
@rsempe rsempe deleted the feat-dunning branch August 23, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants