Feat(anrok): add fields to graphql response on applied taxes #2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annvelents
force-pushed
the
feat-anrok-add-fields-to-invoice-applied-taxes
branch
from
fcbf5c7
to
303c17c
Compare
annvelents
force-pushed
the
feat-anrok-add-fields-to-invoice-applied-taxes
branch
from
303c17c
to
b5675fb
Compare
rsempe
reviewed
Aug 26, 2024
lovrocolic
reviewed
Aug 26, 2024
annvelents
force-pushed
the
feat-anrok-add-fields-to-invoice-applied-taxes
branch
from
b599aca
to
529d34a
Compare
rsempe
approved these changes
Aug 26, 2024
lovrocolic
pushed a commit
that referenced
this pull request
Aug 26, 2024
## Context On FE to be able to show differently taxes applied on all line items vs on few only within the invoice, we need to specify on the applied_tax if it's applicable on the whole invoice and to be able to show different translation for the taxes depending on their code, we want to send tax_cod with applied tax as well ## Description - added tax_code - and applied_on_whole_invoice to Invoice::AppliedTax graphql type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
On FE to be able to show differently taxes applied on all line items vs on few only within the invoice, we need to specify on the applied_tax if it's applicable on the whole invoice
and to be able to show different translation for the taxes depending on their code, we want to send tax_cod with applied tax as well
Description
to Invoice::AppliedTax graphql type