feat (tax-integrations): Use Anrok taxes in subscription invoices flow #2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovrocolic
force-pushed
the
qa-anrok-subscription-invoices
branch
2 times, most recently
from
ca87a2c
to
31a1300
Compare
ivannovosad
reviewed
Aug 28, 2024
ivannovosad
approved these changes
Aug 28, 2024
…2378) ## Context Added error processing on draft invoices, finalization of draft invoices with tax error details ## Description Added: - Fetch taxes from anrok/create_draft_invoice service if calculating fees and applying taxes for draft invoices - Fetch taxes from anrok/create_invoice service if calculating fees and applying taxes for draft invoices that is being finalized - From refresh_draft_and_finalize service if there was a tax error we now update invoice to failed state and do not send any notifications - Return from finalize_service if it was a tax_error while fetching taxes - Reset all invoice values when refreshing it - not only delete values, but also set 0 to computed values, so when we fail we have 0s instead of previous calculated values
fail with validation failure when fail to refresh invoice
lovrocolic
force-pushed
the
qa-anrok-subscription-invoices
branch
from
176a3aa
to
47dda19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently integration with tax provider Anrok is being implemented.
Description
This PR uses all existing Anrok logic on subscription and draft invoices.
If customer is connected to Anrok, its taxes should be used. All services and Anrok core logic is already implemented and merged on main. This is just logic that consumes it for subscription and draft invoices