feat(customer_type): Gocardless add firstname and lastname #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunomiguelpinto
changed the title
brunomiguelpinto
changed the title
ivannovosad
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We currently only create Lago customers as companies, but there is a need to support both companies and individuals. This change is motivated by scenarios where customers may be a mix of B2B and B2C, and where external integrations require handling both Contacts and Companies.
Description
We currently only create GoCardless customers with a limited set of details. However, there is a need to ensure that company name, first name, and last name are included when available.
the additional customer attributes to GoCardless, specifically:
given_name: If the customer's firstname is present, it will be sent.family_name: If the customer's lastname is present, it will be sent.