Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug - Fix check for invoice.closed? in Invoices::AdvanceChargesService #2572

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

nudded
Copy link
Contributor

@nudded nudded commented Sep 12, 2024

Description

This check returns true if the invoice is nil, this is not intended.

@nudded nudded changed the title bug - Fix check for invoice.closed? in AdvanceChargesService bug - Fix check for invoice.closed? in Invoices::AdvanceChargesService Sep 12, 2024
@nudded nudded merged commit 4f2c57c into main Sep 12, 2024
6 checks passed
@nudded nudded deleted the bug-invoice-closed-check branch September 12, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants