-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete React podspec dependency #382
Conversation
Thx :) |
Hi! I'm sorry to hear that. Let me run some detailed tests first and then I would be able to tell you if my premise was wrong after all and if this PR should be reverted, OK? |
@angly-cat OK, thanks for helping with this. |
@@ -17,7 +17,6 @@ Pod::Spec.new do |s| | |||
|
|||
s.preserve_paths = '*.js' | |||
|
|||
s.dependency 'React' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If/when you revert. This can be more precise by changing it to:
s.dependency 'React/Core'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, but I will just revert it back, other plugins also just have s.dependency 'React'
@HazAT Yes, apparently this was a mistake from my side. I'm sorry for that. Please revert this PR. And it seems like it's not possible to use pod version of |
I'm using Sentry with a
React Native
-only app.react-native link react-native-sentry
addsRNSentry
as a pod. If I includeReact
as a pod inPodfile
, all is ok. But I explicitly do not includeReact
as a pod in myReact Native
-only app, because it has many downsides and using-react-as-a-pod-issues. In this caseSentry
-pod forces CocoaPods to satisfy this (check the changes of this PR)React
-dependency by installing old/obsolete/deprecatedReact
0.11
, which breaks even more things.Resolution is to remove this dependency.
Check corresponding issues in another repos:
invertase/react-native-firebase#325
invertase/react-native-firebase#324
ocetnik/react-native-background-timer#71