Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: avoid exceeding log length limit #21

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

Minoru
Copy link
Collaborator

@Minoru Minoru commented Apr 13, 2020

Two Travis jobs currently fail because their output exceeds log length limit:

By diffing the output with the last passing job, https://travis-ci.org/github/Koka/gettext-rs/jobs/417123508, I found that Cargo now prints out a progress bar. Travis stores each update of the progress bar as a separate line in the log, which eventually reaches the limit.

This is a known problem (rust-lang/cargo#5721), and I applied the suggested solution, which is: set TERM environment variable to dumb to disable the progress bar. I believe this won't affect the usefulness of the output.

@Minoru
Copy link
Collaborator Author

Minoru commented Apr 14, 2020

Well that didn't work. Back to the drawing board, then.

Sorry about the noise.

@Minoru Minoru marked this pull request as draft April 14, 2020 00:02
@Minoru Minoru force-pushed the bugfix/ci-log-limit-exceeded branch from 60fc1a0 to cd8e004 Compare September 3, 2020 16:43
Recent Cargo versions started printing out a progress bar, which has to
be re-painted every time something is outputted. Since we're using
`-vv`, the progress bar effectively doubles the amount of output.

We now suppress the progress bar in all builds.
@Minoru Minoru force-pushed the bugfix/ci-log-limit-exceeded branch from 0724c33 to 965df9a Compare September 3, 2020 19:04
@Minoru Minoru marked this pull request as ready for review September 3, 2020 19:05
@Minoru
Copy link
Collaborator Author

Minoru commented Sep 3, 2020

My previous attempt failed because the TERM environment variable didn't propagate into the Docker container. Doing that fixed the issue.

I'll merge this once the build finishes.

@Minoru
Copy link
Collaborator Author

Minoru commented Sep 3, 2020

[The build finished successfully[(https://travis-ci.org/github/Koka/gettext-rs/builds/723892058), but GitHub doesn't show that for whatever reason :( Merging this still.

@Minoru
Copy link
Collaborator Author

Minoru commented Sep 3, 2020

Ah wait, I can't merge because because the status is required for merging. @Koka, can you merge this please?

@Koka Koka merged commit b8c69cd into gettext-rs:master Sep 3, 2020
@Koka
Copy link
Collaborator

Koka commented Sep 3, 2020

@Minoru done!

@Minoru Minoru deleted the bugfix/ci-log-limit-exceeded branch September 3, 2020 19:26
@Minoru
Copy link
Collaborator Author

Minoru commented Sep 3, 2020

Thanks! I notice there are no Travis statuses on recent commits to master either, researching that now.

@Minoru
Copy link
Collaborator Author

Minoru commented Sep 3, 2020

@Koka, this and this indicate that you might need to revoke access to Travis and then grant it again to fix this. Can you please do this?

I was supposed to help you, not pile more work onto you! >_< Sorry about that.

@Koka
Copy link
Collaborator

Koka commented Sep 3, 2020

Thanks, I'll try a bit later

@Koka
Copy link
Collaborator

Koka commented Sep 4, 2020

Tried with no luck, apparently github integration with older travis-ci.org is broken, I'll try to migrate to newer travis-ci.com

@Koka
Copy link
Collaborator

Koka commented Sep 4, 2020

Apparently it works properly now

@Minoru
Copy link
Collaborator Author

Minoru commented Sep 4, 2020

Still doesn't work for PRs submitted from my fork (the "branch" check is never reported), but I can push directly to this repo and it works then, so it's not a big deal. Thanks for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants