Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cfg_aliases to wgpu-core and wgpu-hal #5055

Merged
merged 3 commits into from
Jan 14, 2024
Merged

Add cfg_aliases to wgpu-core and wgpu-hal #5055

merged 3 commits into from
Jan 14, 2024

Conversation

daxpedda
Copy link
Contributor

Follow up to #4935 as requested.

@daxpedda daxpedda requested a review from a team as a code owner January 12, 2024 22:03
daxpedda
daxpedda commented Jan 12, 2024
View reviewed changes
wgpu-hal/src/gles/mod.rs Outdated Show resolved Hide resolved
Wumpf
Wumpf previously requested changes Jan 13, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it, thank you so much!
Let's try to remove #![allow(clippy::mismatched_target_os)] (see comment) and then 🚢

@daxpedda daxpedda requested a review from Wumpf January 13, 2024 14:14
cwfitzgerald
cwfitzgerald approved these changes Jan 14, 2024
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code go bye bye!

@cwfitzgerald cwfitzgerald merged commit 580340f into gfx-rs:trunk Jan 14, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

@Wumpf Wumpf Awaiting requested review from Wumpf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daxpedda @Wumpf @cwfitzgerald