Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll back once_cell to 1.19.0. #6370

Merged
merged 1 commit into from
Oct 4, 2024

Commits on Oct 4, 2024

  1. Roll back once_cell to 1.19.0.

    Roll back `wgpu`'s dependencies on `once_cell` from 1.20.1 to 1.19.0.
    
    Version 1.20.1 of `once_cell` added a more complex conditional
    dependency on `portable-atomic`, which causes `cargo metadata` to
    incorrectly list `portable-atomic` as a dependency even though the
    given `once_cell` features are not enabled.
    
    The Firefox source tree uses `cargo vet` to enforce supply-chain
    auditing. Since `cargo vet` depends on `cargo metadata` to tell it
    what crates are going to be included in the tree, the extraneous
    dependency above adds `portable-atomic` to the set of sources we must
    audit. Since `portable-atomic` is roughly 50kloc, we would like to
    avoid this.
    
    Nothing in `wgpu` actually needs `once_cell` 1.20; it was upgraded by
    Dependabot. So the simplest workaround for the moment is to roll back
    the version.
    jimblandy committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    fd1b716 View commit details
    Browse the repository at this point in the history