Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ggml : fix BLAS with unsupported types #9775

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ggml : fix BLAS with unsupported types #9775

wants to merge 2 commits into from
+75 −74

Conversation

slaren
Copy link
Collaborator

@slaren slaren commented Oct 7, 2024

  • Do not use BLAS with types that don't have to_float functions
  • Change ggml_internal_get_type_traits to return a const pointer to avoid copies in sensitive paths
  • Rename ggml_internal_get_type_traits to ggml_get_type_traits

Fixes #9766

@slaren
ggml : do not use BLAS with types without to_float
e2e10ff 
ggml : return pointer from ggml_internal_get_type_traits to avoid unnecessary copies
@slaren
ggml : rename ggml_internal_get_type_traits -> ggml_get_type_traits
d74105f 
it's not really internal if everybody uses it
@slaren slaren mentioned this pull request Oct 7, 2024
Open
@github-actions github-actions bot added testing Everything test related Vulkan Issues specific to the Vulkan backend examples ggml changes relating to the ggml tensor library for machine learning labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
examples ggml changes relating to the ggml tensor library for machine learning testing Everything test related Vulkan Issues specific to the Vulkan backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: BLAS causes Segmentation Fault
2 participants
@slaren @ggerganov