fix: checksum calculation #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ghedo can you review this pr ? |
|
@sibicramesh it'd be nice if you could add a test case (ideally for both even and odd lengths). Otherwise lgtm. |
|
Also, sorry for the delay. |
MaxAFriedrich
referenced
this pull request
in MaxAFriedrich/go.pkt
Sep 6, 2023
MaxAFriedrich
referenced
this pull request
in MaxAFriedrich/go.pkt
Sep 6, 2023
…" (ghedo#4) This reverts commit 1af745e. We will leave the master to refer to github.com/ghedo so that we do not pull in this change to any upstream PRs. The change to the module name will be put on the branch called `go-mod` and this is the branch that should be referenced from any import statements in aporeto code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the last byte to the checksum incase of odd lengths.