Skip to content

Commit

Permalink
Values: Enable controller.enableAnnotationValidations by default. (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
Gacko committed Oct 18, 2023
1 parent d1a5365 commit 7d7c9cd
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ and this project's packages adheres to [Semantic Versioning](http://semver.org/s

## [Unreleased]

### Changed

- Values: Enable `controller.enableAnnotationValidations` by default. ([#552](https://github.com/giantswarm/ingress-nginx-app/pull/552))\
**NOTE:** This change affects existing, new & updated `Ingress` resources. Upstream is enabling this by default, too: https://github.com/kubernetes/ingress-nginx/issues/10186.

## [3.1.1] - 2023-10-18

### Changed
Expand Down
2 changes: 1 addition & 1 deletion helm/ingress-nginx/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ Please ensure that cert-manager is correctly installed and configured.
| controller.dnsConfig | object | `{}` | Optionally customize the pod dnsConfig. |
| controller.dnsPolicy | string | `"ClusterFirst"` | Optionally change this to ClusterFirstWithHostNet in case you have 'hostNetwork: true'. By default, while using host network, name resolution uses the host's DNS. If you wish nginx-controller to keep resolving names inside the k8s network, use ClusterFirstWithHostNet. |
| controller.electionID | string | `""` | Election ID to use for status update, by default it uses the controller name combined with a suffix of 'leader' |
| controller.enableAnnotationValidations | bool | `false` | |
| controller.enableAnnotationValidations | bool | `true` | |
| controller.enableMimalloc | bool | `true` | Enable mimalloc as a drop-in replacement for malloc. # ref: https://github.com/microsoft/mimalloc # |
| controller.enableTopologyAwareRouting | bool | `false` | This configuration enables Topology Aware Routing feature, used together with service annotation service.kubernetes.io/topology-mode="auto" Defaults to false |
| controller.existingPsp | string | `""` | Use an existing PSP instead of creating one |
Expand Down
2 changes: 1 addition & 1 deletion helm/ingress-nginx/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ commonLabels: {}

controller:
name: controller
enableAnnotationValidations: false
enableAnnotationValidations: true
image:
## Keep false as default for now!
chroot: false
Expand Down

0 comments on commit 7d7c9cd

Please sign in to comment.