allow toggling of the status update flag (#151)

giantswarm · Dec 9, 2020 · ecf23f1 · ecf23f1
1 parent 4a23cda
commit ecf23f1
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project's packages adheres to [Semantic Versioning](http://semver.org/s
 
 ## [Unreleased]
 
+### Added
+
+- Allow toggling of the `--update-status` flag. Disabling this feature stops NGINX IC from updating Ingress Loadbalancer status fields. ([#151](https://github.com/giantswarm/nginx-ingress-controller-app/pull/151))
+
 ## [1.11.0] - 2020-11-18
 
 ### Added

diff --git a/helm/nginx-ingress-controller-app/templates/controller-deployment.yaml b/helm/nginx-ingress-controller-app/templates/controller-deployment.yaml
@@ -97,6 +97,7 @@ spec:
         - --validating-webhook-certificate=/usr/local/certificates/cert
         - --validating-webhook-key=/usr/local/certificates/key
         {{- end }}
+        - --update-status={{ .Values.controller.updateIngressStatus }}
         securityContext:
           allowPrivilegeEscalation: true
           capabilities:

diff --git a/helm/nginx-ingress-controller-app/values.schema.json b/helm/nginx-ingress-controller-app/values.schema.json
@@ -419,6 +419,9 @@
                 "terminationGracePeriodSeconds": {
                     "type": "integer"
                 },
+                "updateIngressStatus": {
+                    "type": "boolean"
+                },
                 "userID": {
                     "type": "integer"
                 }

diff --git a/helm/nginx-ingress-controller-app/values.yaml b/helm/nginx-ingress-controller-app/values.yaml
@@ -309,6 +309,12 @@ controller:
       tolerations: []
       runAsUser: 2000
 
+  # controller.updateIngressStatus
+  # Enables updating of the loadbalancer status of Ingress objects which this controller is reconciling. Unless you are
+  # managing DNS for ingresses via an external method, this should always be left enabled.
+  # Disabling updates of Ingress status allows two parallel NGINX IC deployments to reconcile the same Ingresses.
+  updateIngressStatus: true
+
   # controller.enableMimalloc
   # Enables mimalloc as a drop-in replacement for malloc, reduces the memory utilization.
   # For additional options it provides see https://github.com/microsoft/mimalloc#environment-options