Skip to content

Commit

Permalink
GitHub: Rework pull request template. (#466)
Browse files Browse the repository at this point in the history
  • Loading branch information
Gacko committed Oct 18, 2023
1 parent 638e03f commit f372671
Showing 1 changed file with 8 additions and 21 deletions.
29 changes: 8 additions & 21 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,25 +1,12 @@
<!--
@team-cabbage will be automatically requested for review once
this PR has been submitted.
@team-cabbage will be automatically requested for review once this PR has been submitted.
-->

### Tests on workload clusters (not always required)
For changes in the chart, chart templates and container images, I executed the following tests, using the `hello-world` app, to verify them in live environments:

For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:

| Test / Provider | AWS | Azure | KVM |
| --- | --- | --- | --- |
| Upgrade from previous version | | | |
| Existing Ingress resources are reconciled correctly | | | |
| Fresh install | | | |
| Fresh Ingress resources are reconciled correctly | | | |

Testing was done using `hello-world-app`.

Hint for KVM:

```
kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:127.0.0.1:8080" "http://$ingress_domain" -v
```
| Test / Provider | AWS | Azure |
| ------------------------------------------- | --- | ----- |
| Upgrade from previous version | | |
| Existing `Ingress` resources are reconciled | | |
| Fresh install | | |
| Fresh `Ingress` resources are reconciled | | |

0 comments on commit f372671

Please sign in to comment.