-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
GitHub: Rework pull request template. (#466)
- Loading branch information
Showing
1 changed file
with
8 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,12 @@ | ||
<!-- | ||
@team-cabbage will be automatically requested for review once | ||
this PR has been submitted. | ||
@team-cabbage will be automatically requested for review once this PR has been submitted. | ||
--> | ||
|
||
### Tests on workload clusters (not always required) | ||
For changes in the chart, chart templates and container images, I executed the following tests, using the `hello-world` app, to verify them in live environments: | ||
|
||
For changes in the chart, chart templates, and ingress controller container images, I executed the following tests | ||
to verify them working in live enviromnents: | ||
|
||
| Test / Provider | AWS | Azure | KVM | | ||
| --- | --- | --- | --- | | ||
| Upgrade from previous version | | | | | ||
| Existing Ingress resources are reconciled correctly | | | | | ||
| Fresh install | | | | | ||
| Fresh Ingress resources are reconciled correctly | | | | | ||
|
||
Testing was done using `hello-world-app`. | ||
|
||
Hint for KVM: | ||
|
||
``` | ||
kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80 | ||
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:127.0.0.1:8080" "http://$ingress_domain" -v | ||
``` | ||
| Test / Provider | AWS | Azure | | ||
| ------------------------------------------- | --- | ----- | | ||
| Upgrade from previous version | | | | ||
| Existing `Ingress` resources are reconciled | | | | ||
| Fresh install | | | | ||
| Fresh `Ingress` resources are reconciled | | | |