Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update image to v0.41.2 #133

Merged
merged 3 commits into from
Nov 17, 2020
Merged

Update image to v0.41.2 #133

merged 3 commits into from
Nov 17, 2020

Conversation

glitchcrab
Copy link
Member

This PR:

  • fixes bugs in the controller (no changes to the upstream chart).

@glitchcrab glitchcrab requested a review from a team November 17, 2020 13:28
@glitchcrab glitchcrab self-assigned this Nov 17, 2020
@glitchcrab
Copy link
Member Author

perf test run failed as the cluster was never created. in retrospect I don't think we need this test for this PR.

@glitchcrab
Copy link
Member Author

deployed nginx to an aws cluster, created helloworld deployment with ingress - all worked as expected.

@glitchcrab glitchcrab requested a review from a team November 17, 2020 15:18
ced0ps
ced0ps approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@ced0ps ced0ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMIT

@glitchcrab glitchcrab closed this Nov 17, 2020
@glitchcrab glitchcrab reopened this Nov 17, 2020
@glitchcrab glitchcrab merged commit 29a8e83 into master Nov 17, 2020
@glitchcrab glitchcrab deleted the update-to-0.41 branch November 17, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ced0ps ced0ps ced0ps approved these changes

Assignees

@glitchcrab glitchcrab

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glitchcrab @ced0ps