Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow toggling of the status update flag #151

Merged
merged 1 commit into from
Dec 9, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project's packages adheres to [Semantic Versioning](http://semver.org/s

## [Unreleased]

### Added

- Allow toggling of the `--update-status` flag. Disabling this feature stops NGINX IC from updating Ingress Loadbalancer status fields. ([#151](https://github.com/giantswarm/nginx-ingress-controller-app/pull/151))

## [1.11.0] - 2020-11-18

### Added
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ spec:
- --validating-webhook-certificate=/usr/local/certificates/cert
- --validating-webhook-key=/usr/local/certificates/key
{{- end }}
- --update-status={{ .Values.controller.updateIngressStatus }}
securityContext:
allowPrivilegeEscalation: true
capabilities:
Expand Down
3 changes: 3 additions & 0 deletions helm/nginx-ingress-controller-app/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,9 @@
"terminationGracePeriodSeconds": {
"type": "integer"
},
"updateIngressStatus": {
"type": "boolean"
},
"userID": {
"type": "integer"
}
Expand Down
6 changes: 6 additions & 0 deletions helm/nginx-ingress-controller-app/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,12 @@ controller:
tolerations: []
runAsUser: 2000

# controller.updateIngressStatus
# Enables updating of the loadbalancer status of Ingress objects which this controller is reconciling. Unless you are
# managing DNS for ingresses via an external method, this should always be left enabled.
# Disabling updates of Ingress status allows two parallel NGINX IC deployments to reconcile the same Ingresses.
updateIngressStatus: true

# controller.enableMimalloc
# Enables mimalloc as a drop-in replacement for malloc, reduces the memory utilization.
# For additional options it provides see https://github.com/microsoft/mimalloc#environment-options
Expand Down