-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Kubernetes 1.16.3 and re-enable basic app e2e test #16
Conversation
@@ -1,4 +1,4 @@ | |||
apiVersion: extensions/v1beta1 | |||
apiVersion: policy/v1beta1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a new release because of the PSP.
package templates | ||
|
||
// IngressControllerValues sets legacy to true so the controller service uses | ||
// node ports. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The chart defaults to creating a load balancer for CAPI clusters. For KIND we fall back to legacy and use a node port. This is so the helm release test passes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Towards https://github.com/giantswarm/giantswarm/issues/7675