Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate controller service for external-dns #169

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Annotate controller service for external-dns #169

merged 1 commit into from
Feb 3, 2021

Conversation

glitchcrab
Copy link
Member

This PR:

  • adds an annotation to the controller service. This will be used by external-dns to limit the resources it reconciles.

See giantswarm/external-dns-app#49

@glitchcrab glitchcrab requested a review from a team February 1, 2021 17:01
@glitchcrab glitchcrab self-assigned this Feb 1, 2021
@glitchcrab glitchcrab changed the title Annotate controller for external-dns Annotate controller service for external-dns Feb 1, 2021
@glitchcrab glitchcrab mentioned this pull request Feb 2, 2021
Merged
2 tasks
webwurst
webwurst approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@webwurst webwurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but did not test

@glitchcrab glitchcrab merged commit 3c89be6 into master Feb 3, 2021
@glitchcrab glitchcrab deleted the ext-dns-annotate-service branch February 3, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webwurst webwurst webwurst approved these changes

Assignees

@glitchcrab glitchcrab

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glitchcrab @webwurst