Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow override of SSL protocols #17

Merged
merged 2 commits into from
Jan 21, 2020
Merged

Allow override of SSL protocols #17

merged 2 commits into from
Jan 21, 2020

Conversation

QuentinBisson
Copy link
Contributor

@QuentinBisson QuentinBisson commented Jan 6, 2020 •
edited
Loading

Allow override of ssl-protocols

@QuentinBisson QuentinBisson added the enhancement New feature or request label Jan 6, 2020
@QuentinBisson QuentinBisson requested a review from a team January 6, 2020 11:44
@QuentinBisson QuentinBisson self-assigned this Jan 6, 2020
@corest
Copy link
Contributor

corest commented Jan 6, 2020

Would be nice to have some changelog update

@QuentinBisson
Copy link
Contributor Author

@corest It should be better now :)
Can someone in @giantswarm/team-batman explain to me how to release v1.1.2 once it is merged?
Is it just a github release with a tag?

@sslavic
Copy link

sslavic commented Jan 7, 2020

Was this tested, with default settings and that override works?

@QuentinBisson
Copy link
Contributor Author

QuentinBisson commented Jan 7, 2020 •
edited
Loading

I asked in slack how to test it. I will do it now. I did not know it was only for releases after 10.1.0

@corest
Copy link
Contributor

corest commented Jan 20, 2020

Is this still a valid issue?

@QuentinBisson
Copy link
Contributor Author

@corest yes, but I had other issues to work on in the last week. I will try to pick up testing this week or the next

@QuentinBisson
Copy link
Contributor Author

@sslavic it was tested on godsmack

pipo02mix
pipo02mix approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@pipo02mix pipo02mix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@QuentinBisson QuentinBisson merged commit 11c7b77 into master Jan 21, 2020
@QuentinBisson QuentinBisson deleted the add-ssl-protocols-options branch January 21, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pipo02mix pipo02mix pipo02mix approved these changes

Assignees

@QuentinBisson QuentinBisson

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QuentinBisson @corest @sslavic @pipo02mix