Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support user-provided annotations #170

Merged
merged 4 commits into from
Feb 3, 2021
Merged

support user-provided annotations #170

merged 4 commits into from
Feb 3, 2021

Conversation

glitchcrab
Copy link
Member

This PR:

  • allows extra annotations to be added to the controller deployment via the values file.

@glitchcrab glitchcrab requested a review from a team February 3, 2021 11:08
@glitchcrab glitchcrab self-assigned this Feb 3, 2021
@glitchcrab
Copy link
Member Author

tested - works fine. annotations are added if provided and ignored if the array is left empty.

piontec
piontec approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@piontec piontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glitchcrab glitchcrab merged commit 0c4743f into master Feb 3, 2021
@glitchcrab glitchcrab deleted the allow-additional-annotations branch February 3, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webwurst webwurst webwurst approved these changes

@piontec piontec piontec approved these changes

Assignees

@glitchcrab glitchcrab

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glitchcrab @webwurst @piontec