remove-conflicting-webhook-api-versions

[QuentinBisson]

@giantswarm/app-squad-nginx

[ubergesundheit]

LGTM if tested

[webwurst]

@QuentinBisson Can you explain why this conflicting? I would understand it as v1beta1 or v1. When removing v1 does this basically mean "Don't validate v1"? If this solves a current issue I am fine merging. But probably we should create a follow up issue to bring in validation for v1 again. Or I am missing something here :)

[QuentinBisson]

Sure, so basically, the default validation webhook matching mode is Equivalent by default since webhook v1. This policy will ensure that the tree of apiversions will be valid according the the webhook.

I am not really sure if this issue is from the nginx ingress controller or the actual validating webhook code hence I opened a kubernetes issue upstream kubernetes/kubernetes#99352

To make it worked I followed the nginx PR upstream and this removed the v1: kubernetes/ingress-nginx@703c2d6#diff-994d32c26c5c0bfa793222a8a5171ed8e4ea78fc850353bb98602b76751f4c2d
This PR defines v1beta1 until k8s 1.22. Once this is released, the webhook will migrate to v1

I think the issue with the equivalent webhook match policy is that there should be no overlap in the api versions defined hence my issue

I tested it on orion and it worked.

[webwurst]

Thanks for the explanation! :)