Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart upgrade 2021 02 #179

Merged
merged 9 commits into from
Feb 26, 2021
Merged

Chart upgrade 2021 02 #179

merged 9 commits into from
Feb 26, 2021

Conversation

ubergesundheit
Copy link
Member

@ubergesundheit ubergesundheit commented Feb 23, 2021 •
edited
Loading

This PR upgrades the used nginx ingress controller image to 0.44.0 and kube-webhook-certgen image to 1.5.1

This was referenced Feb 23, 2021
Closed
Closed
@ubergesundheit ubergesundheit marked this pull request as ready for review February 24, 2021 15:23
@ubergesundheit ubergesundheit requested a review from a team February 24, 2021 15:23
@ubergesundheit ubergesundheit requested a review from a team February 24, 2021 15:24
@webwurst
Copy link
Contributor

There is something wrong with the "run-perf-tests". Probably because of deprecated Helm version helm-v2.16.5 and so "Failed to fetch https://kubernetes-charts.storage.googleapis.com/index.yaml : 403 Forbidden". And there also a complaint about good old "/bin/bash: kind-app-testing.sh: command not found".

Else looks good.

@ubergesundheit
Copy link
Member Author

Yeah the kat based test ist broken at least since last release.. I need to invest some time to fix (maybe in cooldown)

piontec
piontec approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@piontec piontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The kat test won't be easy to fix, as it's all helm2 and requires a GS cluster. Maybe we should think about creating this cluster in CI and then passing as external cluster to abs to run this test

@ubergesundheit
Copy link
Member Author

I want to pursue a tekton based approach. IMO the other teams did phenomenal groundwork which can be reused for this

@ubergesundheit ubergesundheit merged commit 048ddef into master Feb 26, 2021
@ubergesundheit ubergesundheit deleted the chart-upgrade-2021-02 branch February 26, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piontec piontec piontec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ubergesundheit @webwurst @piontec