Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use v0.45.0 for controller image tag #188

Merged
merged 17 commits into from
Apr 15, 2021
Merged

Use v0.45.0 for controller image tag #188

merged 17 commits into from
Apr 15, 2021

Conversation

ubergesundheit
Copy link
Member

@ubergesundheit ubergesundheit commented Apr 7, 2021 •
edited
Loading

This PR updates the controller image to 0.45.0

Other changes:

  • The monitoring port in the values file has been changed to 10254
  • The values schema for resources has been fixed
  • tests on kube-app-testing and go based integration tests have been replaced by tests running through app-build-suite

ubergesundheit and others added 17 commits April 7, 2021 09:22
@ubergesundheit
Use v0.45.0 for controller image tag
593e13c
@ubergesundheit
add Changelog entry
9113243
@ubergesundheit
update architect-orb to 2.5.0
8028a8e
@ubergesundheit
update appVersion and version in Chart.yaml
1709a62
@ubergesundheit
make linter happy
e12c0c9
@ubergesundheit
first tryout abs tests
da83087
@ubergesundheit
trigger ci
d8b25d5
@ubergesundheit
use dev architect for testing catalogbot ssh change
73170bf
@ubergesundheit
try architect based build
2dbac59
@ubergesundheit
make architect happy
05730be
@ubergesundheit
Revert "try architect based build"
10c698e 
This reverts commit 2dbac59.
@ubergesundheit
Revert "make architect happy"
4d60930 
This reverts commit 05730be.
@ubergesundheit
use 10254 in values for monitoring port
af266b5
@ced0ps
Update values-schema (#189)
8dd8ca6 
* Update values-schema

* Fix schema-values path

* Update changelog

* Bump architect orb
@ubergesundheit
add abs tests
cf959a5
@ubergesundheit
remove kat & go integration test
7f6a6a0
@ubergesundheit
do not replace the appVersion in chart.yaml through abs
533734b
@ubergesundheit ubergesundheit marked this pull request as ready for review April 15, 2021 13:46
@ubergesundheit ubergesundheit requested a review from a team April 15, 2021 13:46
@ubergesundheit
Copy link
Member Author

@piontec can you take a look at the tests? https://github.com/giantswarm/nginx-ingress-controller-app/pull/188/files#diff-ab211efb7db46ad971eb187ba932bc0f489ff32ca5c1ebdeb2cf3b7a42282661

I know the functional test is not perfect but a customer is waiting on the change @ced0ps did to the values schema. We can iterate on the test later if you don't see a show stopper

@ubergesundheit ubergesundheit requested a review from a team April 15, 2021 13:55
@ubergesundheit ubergesundheit mentioned this pull request Apr 15, 2021
Closed
23 tasks
@ubergesundheit ubergesundheit merged commit 3f6d0be into master Apr 15, 2021
@ubergesundheit ubergesundheit deleted the upgrade-nginx-0.45.0 branch April 15, 2021 14:56
@ced0ps
Copy link
Contributor

ced0ps commented Apr 15, 2021

LGTMIT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ubergesundheit @ced0ps