Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to nginx-ingress-controller v1.0.0 #218

Merged
merged 11 commits into from
Sep 9, 2021
Merged

Upgrade to nginx-ingress-controller v1.0.0 #218

merged 11 commits into from
Sep 9, 2021

Conversation

ubergesundheit
Copy link
Member

@ubergesundheit ubergesundheit commented Aug 27, 2021 •
edited
Loading

This PR updates the nginx-ingress-controller-app to use upstream version 1.0.0. It will become Version 2.2.0 of the app.

Important changes:

  • Installs a IngressClass
  • Only works on k8s >= 1.19
  • Only works with Ingress in version networking.k8s.io/v1

@ubergesundheit ubergesundheit marked this pull request as ready for review September 2, 2021 10:37
@ubergesundheit ubergesundheit requested review from a team September 2, 2021 10:37
@webwurst
Copy link
Contributor

webwurst commented Sep 2, 2021

LGTM, didn't run this yet locally, but will give this a try.

pipo02mix
pipo02mix reviewed Sep 8, 2021
View reviewed changes
Copy link
Contributor

@pipo02mix pipo02mix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, just some questions

helm/nginx-ingress-controller-app/templates/controller-deployment.yaml Show resolved Hide resolved
helm/nginx-ingress-controller-app/tests/abs/test_basic_cluster.py Show resolved Hide resolved
ced0ps
ced0ps approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@ced0ps ced0ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMIT

README.md Outdated Show resolved Hide resolved
ubergesundheit and others added 2 commits September 9, 2021 09:13
@ubergesundheit @ced0ps
Update README.md
54def0a 
Co-authored-by: Cedric Kaufmann <60580186+ced0ps@users.noreply.github.com>
@ubergesundheit
add note about watchIngressWithoutClass
d0cd5a8
pipo02mix
pipo02mix approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@pipo02mix pipo02mix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great work

@ubergesundheit ubergesundheit enabled auto-merge (squash) September 9, 2021 11:19
@ubergesundheit ubergesundheit merged commit f320b25 into master Sep 9, 2021
@ubergesundheit ubergesundheit deleted the upgrade-to-upstream-1 branch September 9, 2021 11:31
@ubergesundheit ubergesundheit mentioned this pull request Sep 9, 2021
Closed
28 tasks
@rossf7 rossf7 mentioned this pull request Nov 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webwurst webwurst webwurst left review comments

@pipo02mix pipo02mix pipo02mix approved these changes

@ced0ps ced0ps ced0ps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ubergesundheit @webwurst @pipo02mix @ced0ps