Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy protocol option in the service annotations #23

Merged
merged 3 commits into from
Jan 29, 2020

Conversation

pipo02mix
Copy link
Contributor

We offer the option to setup the proxy protocol but to make it work we need to add the annotation in the Kubernetes service of the IC to tell AWS to create the ELB policy that forwards correctly the requests.

@pipo02mix pipo02mix self-assigned this Jan 29, 2020
@pipo02mix
Copy link
Contributor Author

tested on ginger. It creates the correct policy in the ELB to manage proxy protocol

                {
                    "InstancePort": 31974,
                    "PolicyNames": [
                        "k8s-proxyprotocol-enabled"
                    ]
                },
                {
                    "InstancePort": 32564,
                    "PolicyNames": [
                        "k8s-proxyprotocol-enabled"
                    ]
                }
            ],

@pipo02mix pipo02mix requested review from a team January 29, 2020 11:09
@sslavic
Copy link

sslavic commented Jan 29, 2020

Please start 1.2.1 or 1.3.0 changelog.

There's 0.28.0 upstream, would be nice to include it together in next release, if not also modsecurity config support.

Copy link

@sslavic sslavic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once changelog is added LGTM

@pipo02mix pipo02mix merged commit 5c50738 into master Jan 29, 2020
@pipo02mix pipo02mix deleted the proxy_protocol branch January 29, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants