Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump used container version to 1.1.1 #264

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Bump used container version to 1.1.1 #264

merged 1 commit into from
Jan 17, 2022

Conversation

ubergesundheit
Copy link
Member

Tests on workload clusters (not always required)

In order to verify that my changes also work on, I did the following tests:

AWS

  • Upgrade from previous version works
  • Existing Ingress resources are reconciled correctly (change domain, see if its available)
  • Fresh install works
  • Fresh Ingress resources are reconciled correctly

Azure

  • Upgrade from previous version works
  • Existing Ingress resources are reconciled correctly (change domain, see if its available)
  • Fresh install works
  • Fresh Ingress resources are reconciled correctly

KVM

Hint:

kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
curl -H "Host: host.configured.in.ingress" localhost:8080
  • Upgrade from previous version works
  • Existing Ingress resources are reconciled correctly (change domain, see if its available)
  • Fresh install works
  • Fresh Ingress resources are reconciled correctly

@ubergesundheit ubergesundheit marked this pull request as ready for review January 17, 2022 09:29
@ubergesundheit ubergesundheit requested a review from a team as a code owner January 17, 2022 09:29
ced0ps
ced0ps approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@ced0ps ced0ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubergesundheit ubergesundheit merged commit c1e0f14 into master Jan 17, 2022
@ubergesundheit ubergesundheit deleted the upgrade-to-upstream-1.1.1 branch January 17, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ced0ps ced0ps ced0ps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ubergesundheit @ced0ps