Enable NodePort Service just for legacy Azure tenant clusters #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sslavic
force-pushed
the
nodeport-non-aws
branch
from
5e74ca6
to
d583524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing legacy AWS WIP release giantswarm/releases#88 a regression (introduced via #12) was observed - nginx NodePort Service installation is being attempted as part of installing App chart, even though for legacy aws (and kvm) clusters one such service gets already created via ignition.
This PR simplifies NodePort Service template in nginx IC App - service enabled flag is disabled by default, and it gets flipped on only for legacy Azure by legacy cluster-operator (see https://github.com/giantswarm/cluster-operator/blob/legacy/service/controller/resource/clusterconfigmap/desired.go#L62-L74)
For aws node pool clusters LoadBalancer Service continues to be installed as before.
In this PR I've bumped minor version of nginx IC App to 1.5.0 as I plan to include, via another followup PR, in same release also upgrade to upstream nginx 0.29.0 to as a mitigation for https://github.com/giantswarm/giantswarm/issues/8707 (certificate validation resiliency was improved in latest go releases, and latest nginx is being built with latest go - see upstream issue kubernetes/ingress-nginx#4828 (comment) and changelog https://github.com/kubernetes/ingress-nginx/blob/master/Changelog.md)
Plan is then to include both changes in legacy WIP releases which are among other things currently waiting for this regression fix: