Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress controller 1.1.3 #292

Merged
merged 5 commits into from
Apr 4, 2022
Merged

Ingress controller 1.1.3 #292

merged 5 commits into from
Apr 4, 2022

Conversation

ubergesundheit
Copy link
Member

@ubergesundheit ubergesundheit commented Apr 1, 2022

This PR: (Toward giantswarm/roadmap#876)

  • Configures controller flag --ingress-class to use configuration value controller.ingressClassResource.name. This enables backwards compatibility with kubernetes.io/ingress.class annotations on Ingresses.
  • Adds configuration value ingressClassByName to enable or disable processing IngressClass per name (additionally as per spec.controller) (Default: false).
  • Updates controller container image to v1.1.3 to fix CVE-2022-0778 in OpenSSL and CVE-2022-23308 in libxml2. This also upgrades Alpine to 3.14.4 and nginx to 1.19.10.

Tests on workload clusters (not always required)

In order to verify that my changes also work on, I did the following tests:

AWS

  • Upgrade from previous version works
  • Existing Ingress resources are reconciled correctly (change domain, see if its available)
  • Fresh install works
  • Fresh Ingress resources are reconciled correctly

Azure

  • Upgrade from previous version works
  • Existing Ingress resources are reconciled correctly (change domain, see if its available)
  • Fresh install works
  • Fresh Ingress resources are reconciled correctly

KVM

Hint:

kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
curl -H "Host: host.configured.in.ingress" localhost:8080
  • Upgrade from previous version works
  • Existing Ingress resources are reconciled correctly (change domain, see if its available)
  • Fresh install works
  • Fresh Ingress resources are reconciled correctly

@ubergesundheit ubergesundheit marked this pull request as ready for review April 4, 2022 12:36
@ubergesundheit ubergesundheit requested a review from a team as a code owner April 4, 2022 12:36
Copy link

@weatherhog weatherhog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubergesundheit ubergesundheit merged commit b8bdbe8 into master Apr 4, 2022
@ubergesundheit ubergesundheit deleted the ingress-controller-1.1.3 branch April 4, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenSSL CVE-2022-0778
2 participants