Upgrade to nginx-ingress-controller 0.29.0 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
latest nginx ic in kvm 11.1.0 is 1.1.1... so we include all changes from 1.2.0, 1.2.1, 1.3.0, and 1.5.0? Same w Azure and AWS? |
|
Yes, 1.4.0 too. |
Ah right. So I will draft the paragraph release notes for that. Can we create releases with only these changes, so no coordination w other teams needed? |
|
Yes, this is exactly what we're doing with giantswarm/releases#89 AFAIK my answer to your previous related question there still holds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nginx IC 0.29.0 was updated from 1.13.1 to most recent go 1.13.8 which among other things includes fixes hardening certificate validation in go's crypto/x509 package (done in Go 1.13.7), which should help nginx IC panic less i.e. better handle (survive) invalid certificates customers configure as in https://github.com/giantswarm/giantswarm/issues/8707
For complete nginx IC 0.29.0 change log see https://github.com/kubernetes/ingress-nginx/blob/master/Changelog.md#0290
Go 1.13 release notes can be found at https://golang.org/doc/devel/release.html#go1.13
Plan is to release this as 1.5.0 and include it in legacy WIP releases: