Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm/values: Enable topologySpreadConstraints by default. #318

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Jun 16, 2022

Default values are still some kind of optional since they are using whenUnsatisfiable: ScheduleAnyway so pods won't be pending.

Tests on workload clusters (not always required)

For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:

Test / Provider AWS Azure KVM
Upgrade from previous version
Existing Ingress resources are reconciled correctly
Fresh install
Fresh Ingress resources are reconciled correctly

Testing was done using hello-world-app.

Hint for KVM:

kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:127.0.0.1:8080" "http://$ingress_domain" -v

Default values are still some kind of optional since they are using `whenUnsatisfiable: ScheduleAnyway` so pods won't be pending.
@Gacko Gacko requested a review from a team as a code owner June 16, 2022 10:29
@Gacko Gacko enabled auto-merge (squash) June 16, 2022 10:29
@Gacko Gacko disabled auto-merge June 16, 2022 12:19
@Gacko Gacko merged commit a990d7f into master Jun 16, 2022
@Gacko Gacko deleted the feature/topology-spread-constraints branch June 16, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant