Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helpers: Rename resource.default.name to ingress-nginx.fullname. #356

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Helpers: Rename resource.default.name to ingress-nginx.fullname. #356

merged 1 commit into from
Oct 24, 2022

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Oct 24, 2022

This pull request is part of the alignment of our chart with the upstream.

@Gacko Gacko requested a review from a team as a code owner October 24, 2022 10:14
ubergesundheit
ubergesundheit approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@ubergesundheit ubergesundheit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure if this is worth adding a changelog entry (as in: Does the consumer of this app need to know?)

@Gacko
Copy link
Member Author

Gacko commented Oct 24, 2022

I think we can still adjust the changelog on releasing. I'd keep this for now, just as a reminder of what we did, and maybe edit later. Ok?

@Gacko Gacko merged commit 1a1a877 into master Oct 24, 2022
@Gacko Gacko deleted the feature/upstream-alignment/rename-resource.default.name branch October 24, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubergesundheit ubergesundheit ubergesundheit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gacko @ubergesundheit