Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook: Add labels & selectors. #364

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Oct 25, 2022

Tests on workload clusters (not always required)

For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:

Test / Provider AWS
Upgrade from previous version
Existing Ingress resources are reconciled correctly
Fresh install
Fresh Ingress resources are reconciled correctly

Testing was done using hello-world-app.

Hint for KVM:

kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:127.0.0.1:8080" "http://$ingress_domain" -v

@Gacko Gacko requested a review from a team as a code owner October 25, 2022 09:43
@Gacko Gacko enabled auto-merge (squash) October 25, 2022 10:12
@Gacko Gacko force-pushed the feature/upstream-alignment/webhook-labels-selectors branch from c5c9b7d to dfd9eca Compare October 25, 2022 10:45
Copy link
Contributor

@mcharriere mcharriere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Gacko Gacko merged commit 54e6374 into main Oct 26, 2022
@Gacko Gacko deleted the feature/upstream-alignment/webhook-labels-selectors branch October 26, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants