Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook: Align values & functions. #366

Merged
merged 11 commits into from
Nov 1, 2022

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Oct 26, 2022

Tests on workload clusters (not always required)

For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:

Test / Provider AWS Azure KVM
Upgrade from previous version
Existing Ingress resources are reconciled correctly
Fresh install
Fresh Ingress resources are reconciled correctly

Testing was done using hello-world-app.

Hint for KVM:

kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:127.0.0.1:8080" "http://$ingress_domain" -v

@Gacko Gacko requested a review from a team as a code owner October 26, 2022 11:48
@Gacko Gacko force-pushed the feature/upstream-alignment/admission-webhooks branch from ab335c1 to dbcdc83 Compare October 26, 2022 11:53
@Gacko
Copy link
Member Author

Gacko commented Oct 26, 2022

I'm done with aligning the webhook part. Gonna test it by tomorrow.

CHANGELOG.md Outdated Show resolved Hide resolved
@Gacko Gacko force-pushed the feature/upstream-alignment/admission-webhooks branch from 324bfb7 to 9aa6a71 Compare October 27, 2022 06:26
@Gacko Gacko force-pushed the feature/upstream-alignment/admission-webhooks branch from 9aa6a71 to 7c2d667 Compare October 27, 2022 07:24
@Gacko Gacko requested review from webwurst and a team October 27, 2022 16:44
@Gacko
Copy link
Member Author

Gacko commented Oct 27, 2022

I tested those changes on AWS.

@Gacko Gacko enabled auto-merge (squash) October 27, 2022 16:53
@Gacko Gacko disabled auto-merge October 27, 2022 16:54
@Gacko Gacko enabled auto-merge (squash) October 27, 2022 16:54
Copy link
Contributor

@ced0ps ced0ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gacko Gacko merged commit 5ab4aa3 into main Nov 1, 2022
@Gacko Gacko deleted the feature/upstream-alignment/admission-webhooks branch November 1, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants