Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPA: Align to upstream. #369

Merged
merged 13 commits into from
Nov 3, 2022
Merged

HPA: Align to upstream. #369

merged 13 commits into from
Nov 3, 2022

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Nov 3, 2022

Tests on workload clusters (not always required)

For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:

Test / Provider AWS Azure KVM
Upgrade from previous version
Existing Ingress resources are reconciled correctly
Fresh install
Fresh Ingress resources are reconciled correctly

Testing was done using hello-world-app.

Hint for KVM:

kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:127.0.0.1:8080" "http://$ingress_domain" -v

@Gacko Gacko force-pushed the feature/upstream-alignment/hpa branch from 3b8c43e to bc1225f Compare November 3, 2022 13:16
@Gacko Gacko marked this pull request as ready for review November 3, 2022 13:25
@Gacko Gacko requested a review from a team as a code owner November 3, 2022 13:25
Copy link
Contributor

@mcharriere mcharriere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gacko
Copy link
Member Author

Gacko commented Nov 3, 2022

Also wanted to note that it's worth having a look at the single commits since I tried to make them as granular as possible without creating multiple small PRs.

@Gacko Gacko force-pushed the feature/upstream-alignment/hpa branch 2 times, most recently from 902bb7f to 5d408f8 Compare November 3, 2022 16:27
@Gacko Gacko force-pushed the feature/upstream-alignment/hpa branch from 5d408f8 to 03b4a75 Compare November 3, 2022 16:29
@Gacko Gacko enabled auto-merge (squash) November 3, 2022 16:35
@Gacko Gacko merged commit 15792bd into main Nov 3, 2022
@Gacko Gacko deleted the feature/upstream-alignment/hpa branch November 3, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants