Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBAC: Align to upstream. #378

Merged
merged 31 commits into from
Jan 2, 2023
Merged

RBAC: Align to upstream. #378

merged 31 commits into from
Jan 2, 2023

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Nov 10, 2022

Tests on workload clusters (not always required)

For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:

Test / Provider AWS Azure KVM
Upgrade from previous version
Existing Ingress resources are reconciled correctly
Fresh install
Fresh Ingress resources are reconciled correctly

Testing was done using hello-world-app.

Hint for KVM:

kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:127.0.0.1:8080" "http://$ingress_domain" -v

@Gacko Gacko requested a review from a team as a code owner November 10, 2022 16:15
@Gacko Gacko force-pushed the feature/upstream-alignment/rbac branch from 4a9350f to 017d136 Compare November 10, 2022 16:37
Copy link
Contributor

@ced0ps ced0ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM IT

@Gacko Gacko force-pushed the feature/upstream-alignment/rbac branch from bae7f15 to 1ffd1af Compare November 22, 2022 14:34
@Gacko Gacko force-pushed the feature/upstream-alignment/rbac branch from e6f9d9c to a73999e Compare December 7, 2022 11:38
@Gacko Gacko force-pushed the feature/upstream-alignment/rbac branch 4 times, most recently from 172ddef to f96480c Compare December 12, 2022 11:55
metadata:
name: {{ include "ingress-nginx.fullname" . }}-ng
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In before: Renaming works, tested it. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm. It works

@Gacko Gacko force-pushed the feature/upstream-alignment/rbac branch from 2569a26 to 610d200 Compare December 14, 2022 11:56
@Gacko Gacko force-pushed the feature/upstream-alignment/rbac branch from 96aa5c1 to e31b717 Compare December 14, 2022 15:27
@Gacko
Copy link
Member Author

Gacko commented Dec 15, 2022

Upgrade and fresh install works, but want do double check on all providers.

@Gacko Gacko merged commit f8a3010 into main Jan 2, 2023
@Gacko Gacko deleted the feature/upstream-alignment/rbac branch January 2, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants