Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook: Use cert-manager for certificate lifecycle management. #386

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Jan 9, 2023

Tests on workload clusters (not always required)

For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:

Test / Provider AWS Azure KVM
Upgrade from previous version
Existing Ingress resources are reconciled correctly
Fresh install
Fresh Ingress resources are reconciled correctly

Testing was done using hello-world-app.

Hint for KVM:

kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:127.0.0.1:8080" "http://$ingress_domain" -v

@Gacko Gacko requested a review from a team as a code owner January 9, 2023 17:30
@Gacko
Copy link
Member Author

Gacko commented Jan 9, 2023

Note: This is an alignment to upstream, don't blame me for obvious hacks like hard-coded values. Guess I'll propose improvements later.

@Gacko Gacko merged commit 03cf6bc into main Jan 10, 2023
@Gacko Gacko deleted the feature/upstream/admission-webhooks branch January 10, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants