Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPA: Make apiVersion configurable. #387

Merged
merged 1 commit into from
Jan 11, 2023
Merged

HPA: Make apiVersion configurable. #387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project's packages adheres to [Semantic Versioning](http://semver.org/s

- Service: Add CAPA support. ([#380](https://github.com/giantswarm/nginx-ingress-controller-app/pull/380))
- Webhook: Use `cert-manager` for certificate lifecycle management. ([#386](https://github.com/giantswarm/nginx-ingress-controller-app/pull/386))
- HPA: Make `apiVersion` configurable. ([#387](https://github.com/giantswarm/nginx-ingress-controller-app/pull/387))

## [2.21.0] - 2023-01-02

Expand Down
2 changes: 1 addition & 1 deletion helm/nginx-ingress-controller-app/templates/controller-hpa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{{- if and .Values.controller.autoscaling.enabled (or (eq .Values.controller.kind "Deployment") (eq .Values.controller.kind "Both")) -}}
{{- if not .Values.controller.keda.enabled }}

apiVersion: autoscaling/v2beta2
apiVersion: {{ .Values.controller.autoscaling.apiVersion }}
kind: HorizontalPodAutoscaler
metadata:
annotations:
Expand Down
3 changes: 3 additions & 0 deletions helm/nginx-ingress-controller-app/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,9 @@
"annotations": {
"type": "object"
},
"apiVersion": {
"type": "string"
},
"behavior": {
"type": "object"
},
Expand Down
1 change: 1 addition & 0 deletions helm/nginx-ingress-controller-app/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ controller:

# Mutually exclusive with keda autoscaling
autoscaling:
apiVersion: autoscaling/v2
enabled: true
annotations: {}
minReplicas: 2
Expand Down