Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics: Align to upstream. #388

Merged
merged 16 commits into from
Jan 12, 2023
Merged

Metrics: Align to upstream. #388

merged 16 commits into from
Jan 12, 2023

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Jan 11, 2023

Tests on workload clusters (not always required)

For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:

Test / Provider AWS Azure KVM
Upgrade from previous version
Existing Ingress resources are reconciled correctly
Fresh install
Fresh Ingress resources are reconciled correctly

Testing was done using hello-world-app.

Hint for KVM:

kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:127.0.0.1:8080" "http://$ingress_domain" -v

@Gacko Gacko requested a review from a team as a code owner January 11, 2023 15:24
@Gacko Gacko changed the title Metrics Service: Align to upstream. Metrics: Align to upstream. Jan 11, 2023
@Gacko Gacko force-pushed the feature/upstream/metrics-service branch from 1084231 to 11ef58f Compare January 11, 2023 15:32
@Gacko Gacko force-pushed the feature/upstream/metrics-service branch from e4e43f1 to 97f3a27 Compare January 12, 2023 07:55
@Gacko Gacko force-pushed the feature/upstream/metrics-service branch from 97f3a27 to c2f652f Compare January 12, 2023 13:08
@Gacko
Copy link
Member Author

Gacko commented Jan 12, 2023

Tested on AWS & Azure. Even the rename of the Service resource worked like a charm.

@Gacko Gacko merged commit ec2fa64 into main Jan 12, 2023
@Gacko Gacko deleted the feature/upstream/metrics-service branch January 12, 2023 14:26
@Gacko Gacko mentioned this pull request Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants