Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics: Add app.kubernetes.io/component to selector. #393

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Jan 18, 2023

This is already done in the controller-service-webhook.yaml and the deployment pods have the required label.

Tests on workload clusters (not always required)

For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:

Test / Provider AWS Azure KVM
Upgrade from previous version
Existing Ingress resources are reconciled correctly
Fresh install
Fresh Ingress resources are reconciled correctly

Testing was done using hello-world-app.

Hint for KVM:

kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:127.0.0.1:8080" "http://$ingress_domain" -v

@Gacko Gacko requested a review from a team as a code owner January 18, 2023 14:30
@Gacko Gacko force-pushed the feature/metrics/service-selector branch 2 times, most recently from 3a4a468 to a67fc00 Compare January 18, 2023 14:32
@Gacko Gacko changed the title Metrics: Added app.kubernetes.io/component to selector. Metrics: Add app.kubernetes.io/component to selector. Jan 18, 2023
@Gacko Gacko force-pushed the feature/metrics/service-selector branch from a67fc00 to 7f8c2de Compare January 18, 2023 14:33
@Gacko Gacko enabled auto-merge (squash) January 18, 2023 15:41
@Gacko Gacko merged commit e28b2a9 into main Jan 18, 2023
@Gacko Gacko deleted the feature/metrics/service-selector branch January 18, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants