Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable HPA for xs clusters #40

Merged
merged 4 commits into from
Mar 17, 2020
Merged

Disable HPA for xs clusters #40

merged 4 commits into from
Mar 17, 2020

Conversation

sslavic
Copy link

@sslavic sslavic commented Mar 17, 2020

Resource requests are not set for NGINX on XS clusters so it makes no sense to enable HPA for them.

@sslavic sslavic requested review from a team March 17, 2020 14:40
@sslavic sslavic self-assigned this Mar 17, 2020
rossf7
rossf7 approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@rossf7 rossf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sslavic sslavic merged commit fad7a5b into master Mar 17, 2020
@sslavic sslavic deleted the hpa-and-pdb-for-clusters-with-resource-requests branch March 17, 2020 15:02
@sslavic sslavic mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossf7 rossf7 rossf7 approved these changes

Assignees

@sslavic sslavic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sslavic @rossf7