Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small cluster profile resource requests #42

Merged
merged 6 commits into from
Mar 23, 2020
Merged

Fix small cluster profile resource requests #42

merged 6 commits into from
Mar 23, 2020

Conversation

sslavic
Copy link

@sslavic sslavic commented Mar 18, 2020

While testing kvm 11.2.1 WIP release it was uncovered that small cluster profile (encoded with 3) is not being handled correctly - desired resource requests were not being set. This PR fixes the issue.

@sslavic sslavic self-assigned this Mar 18, 2020
@sslavic sslavic changed the title Compare cluster profile as string Fix small cluster profile resource requests Mar 22, 2020
@sslavic sslavic marked this pull request as ready for review March 22, 2020 22:22
@sslavic
Copy link
Author

sslavic commented Mar 22, 2020

Tested on geckon

@sslavic sslavic requested review from a team March 23, 2020 08:14
Copy link
Contributor

@tomahawk28 tomahawk28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sslavic sslavic merged commit 59283ac into master Mar 23, 2020
@sslavic sslavic deleted the fix-compare branch March 23, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants