Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service: Align to upstream. #425

Merged
merged 36 commits into from
Mar 9, 2023
Merged

Service: Align to upstream. #425

merged 36 commits into from
Mar 9, 2023

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Mar 3, 2023

Tests on workload clusters (not always required)

For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:

Test / Provider AWS Azure KVM
Upgrade from previous version
Existing Ingress resources are reconciled correctly
Fresh install
Fresh Ingress resources are reconciled correctly

Testing was done using hello-world-app.

Hint for KVM:

kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:127.0.0.1:8080" "http://$ingress_domain" -v

@Gacko Gacko force-pushed the feature/controller/service branch 2 times, most recently from d9cd3a7 to 9d38229 Compare March 6, 2023 12:40
@Gacko
Copy link
Member Author

Gacko commented Mar 6, 2023

Note for reviewers: I did not align the change in the service's name nor the way we're deciding wether to add node ports or not. The latter would break KVM and will be aligned once I aligned all non-breaking changes (which can be released in minor releases).

@Gacko Gacko force-pushed the feature/controller/service branch 3 times, most recently from e2f4364 to 277fc86 Compare March 7, 2023 12:38
@Gacko Gacko marked this pull request as ready for review March 7, 2023 15:01
@Gacko Gacko requested a review from a team as a code owner March 7, 2023 15:01
@Gacko
Copy link
Member Author

Gacko commented Mar 8, 2023

Did the basic testing on AWS and Azure now, will do some extended testing (migration, new features etc.) on AWS only.

@Gacko Gacko force-pushed the feature/controller/service branch from cd2fd0d to f6fb74b Compare March 8, 2023 19:39
@Gacko Gacko force-pushed the feature/controller/service branch from f6fb74b to b9e5774 Compare March 8, 2023 20:19
@Gacko
Copy link
Member Author

Gacko commented Mar 8, 2023

I literally tested every commit now. Looks good.

Copy link
Contributor

@mcharriere mcharriere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. I left a small comment about the almost-breaking part of the PR, but approved.

CHANGELOG.md Show resolved Hide resolved
@Gacko Gacko merged commit 11da3b7 into main Mar 9, 2023
@Gacko Gacko deleted the feature/controller/service branch March 9, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants