-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service: Align to upstream. #425
Conversation
d9cd3a7
to
9d38229
Compare
Note for reviewers: I did not align the change in the service's name nor the way we're deciding wether to add node ports or not. The latter would break KVM and will be aligned once I aligned all non-breaking changes (which can be released in minor releases). |
e2f4364
to
277fc86
Compare
Did the basic testing on AWS and Azure now, will do some extended testing (migration, new features etc.) on AWS only. |
cd2fd0d
to
f6fb74b
Compare
….nodePorts.udp`.
…ller.service.enableHttps`.
…controller.service.internal.nodePorts.udp`.
f6fb74b
to
b9e5774
Compare
I literally tested every commit now. Looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. I left a small comment about the almost-breaking part of the PR, but approved
.
Tests on workload clusters (not always required)
For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:
Testing was done using
hello-world-app
.Hint for KVM: