Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove digest, as it changes depending on the registry #426

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

mcharriere
Copy link
Contributor

Signed-off-by: Matias Charriere matias@giantswarm.io

Tests on workload clusters (not always required)

For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:

Test / Provider AWS Azure KVM
Upgrade from previous version
Existing Ingress resources are reconciled correctly
Fresh install
Fresh Ingress resources are reconciled correctly

Testing was done using hello-world-app.

Hint for KVM:

kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:127.0.0.1:8080" "http://$ingress_domain" -v

Signed-off-by: Matias Charriere <matias@giantswarm.io>
@mcharriere mcharriere requested a review from a team as a code owner March 3, 2023 09:50
@mcharriere
Copy link
Contributor Author

Docker API v2 computes the digest using the name of the image. Since retagger is being replaced by skopeo, the v2 is used to sync the images.

This means that quay.io and docker.io have different digests. As a quick fix, I'm removing it from here to rely only on the tag, until we find a more permanent solution.

@mcharriere mcharriere enabled auto-merge (squash) March 3, 2023 09:53
@mcharriere mcharriere disabled auto-merge March 3, 2023 09:54
Signed-off-by: Matias Charriere <matias@giantswarm.io>
@mcharriere mcharriere enabled auto-merge (squash) March 3, 2023 09:55
@mcharriere mcharriere merged commit 620d7e8 into main Mar 3, 2023
@mcharriere mcharriere deleted the quick-fix-digest branch March 3, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants