Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpers: Align to upstream. #429

Merged
merged 18 commits into from
Mar 13, 2023
Merged

Helpers: Align to upstream. #429

merged 18 commits into from
Mar 13, 2023

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Mar 12, 2023

Tests on workload clusters (not always required)

For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:

Test / Provider AWS Azure KVM
Upgrade from previous version
Existing Ingress resources are reconciled correctly
Fresh install
Fresh Ingress resources are reconciled correctly

Testing was done using hello-world-app.

Hint for KVM:

kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:127.0.0.1:8080" "http://$ingress_domain" -v

@Gacko Gacko force-pushed the feature/alignment/helpers branch from c664c57 to 8aa80df Compare March 12, 2023 21:18
@Gacko Gacko force-pushed the feature/alignment/helpers branch from b4cfe42 to a61a8ce Compare March 13, 2023 12:59
@Gacko Gacko force-pushed the feature/alignment/helpers branch from a61a8ce to a84d205 Compare March 13, 2023 13:12
@Gacko Gacko marked this pull request as ready for review March 13, 2023 15:34
@Gacko Gacko requested a review from a team as a code owner March 13, 2023 15:34
@Gacko
Copy link
Member Author

Gacko commented Mar 13, 2023

Also tested every commit on its own.

@Gacko Gacko enabled auto-merge (squash) March 13, 2023 15:34
@Gacko Gacko requested a review from webwurst March 13, 2023 15:45
@Gacko Gacko merged commit 39d115c into main Mar 13, 2023
@Gacko Gacko deleted the feature/alignment/helpers branch March 13, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants