Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment: Align to upstream. #433

Merged
merged 81 commits into from
Mar 16, 2023
Merged

Deployment: Align to upstream. #433

merged 81 commits into from
Mar 16, 2023

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Mar 14, 2023

Tests on workload clusters (not always required)

For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:

Test / Provider AWS Azure KVM
Upgrade from previous version
Existing Ingress resources are reconciled correctly
Fresh install
Fresh Ingress resources are reconciled correctly

Testing was done using hello-world-app.

Hint for KVM:

kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:127.0.0.1:8080" "http://$ingress_domain" -v

@Gacko Gacko requested a review from a team as a code owner March 14, 2023 06:24
@Gacko Gacko force-pushed the feature/deployment branch 2 times, most recently from a642409 to cde9406 Compare March 14, 2023 07:57
@ubergesundheit ubergesundheit marked this pull request as draft March 14, 2023 09:20
Copy link
Contributor

@mcharriere mcharriere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gacko Gacko force-pushed the feature/deployment branch 5 times, most recently from 7932078 to 5593e0f Compare March 15, 2023 10:18
@Gacko Gacko force-pushed the feature/deployment branch 19 times, most recently from 349bb5d to 4cf431e Compare March 16, 2023 12:41
@Gacko Gacko merged commit ebbc1ab into main Mar 16, 2023
@Gacko Gacko deleted the feature/deployment branch March 16, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants