Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

capvcd load balancer annotation #439

Merged
merged 2 commits into from
Mar 28, 2023
Merged

capvcd load balancer annotation #439

merged 2 commits into from
Mar 28, 2023

Conversation

vxav
Copy link
Contributor

@vxav vxav commented Mar 28, 2023 •
edited
Loading

Adds an annotation to services type LB on CAPVCD clusters.
Will also replace this for MCs.

Tests on workload clusters (not always required)

For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:

Test / Provider AWS Azure KVM
Upgrade from previous version
Existing Ingress resources are reconciled correctly
Fresh install
Fresh Ingress resources are reconciled correctly

Hint for KVM:

kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:127.0.0.1:8080" "http://$ingress_domain" -v

@vxav vxav marked this pull request as ready for review March 28, 2023 08:32
@vxav vxav requested a review from a team as a code owner March 28, 2023 08:32
@vxav vxav requested a review from a team March 28, 2023 08:33
@vxav vxav force-pushed the set-svc-annotation-for-capvcd-clusters branch from b2d2dc0 to d959412 Compare March 28, 2023 08:47
glitchcrab
glitchcrab approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@glitchcrab glitchcrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iapprove

Gacko
Gacko requested changes Mar 28, 2023
View reviewed changes
Copy link
Member

@Gacko Gacko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also mind the internal service. Thank you!

@vxav
Copy link
Contributor Author

vxav commented Mar 28, 2023

Please also mind the internal service. Thank you!

Thanks @Gacko, addressed in add to internal lb

@vxav vxav merged commit 20cbebf into main Mar 28, 2023
@vxav vxav deleted the set-svc-annotation-for-capvcd-clusters branch March 28, 2023 14:18
@Gacko
Copy link
Member

Gacko commented Mar 29, 2023

It this urgent? If so, feel free to forge a minor release. Otherwise I'll probably do so next week anyway.

@vxav
Copy link
Contributor Author

vxav commented Mar 30, 2023

It can wait for next week, we have a workaround in mc-bootstrap at the moment. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gacko Gacko Gacko approved these changes

@glitchcrab glitchcrab glitchcrab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vxav @Gacko @glitchcrab