Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image: Update to v1.7.0. #440

Merged
merged 1 commit into from
Apr 1, 2023
Merged

Image: Update to v1.7.0. #440

merged 1 commit into from
Apr 1, 2023

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Mar 30, 2023

Tests on workload clusters (not always required)

For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:

Test / Provider AWS Azure KVM
Upgrade from previous version
Existing Ingress resources are reconciled correctly
Fresh install
Fresh Ingress resources are reconciled correctly

Testing was done using hello-world-app.

Hint for KVM:

kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:127.0.0.1:8080" "http://$ingress_domain" -v

@Gacko Gacko requested a review from a team as a code owner March 30, 2023 20:40
@Gacko
Copy link
Member Author

Gacko commented Mar 30, 2023

This PR also includes some minor changes regarding indention and template rendering, nothing functional.

@Gacko Gacko force-pushed the feature/upstream-alignment branch 3 times, most recently from 6c0d92c to d706df0 Compare March 30, 2023 21:06
@Gacko
Copy link
Member Author

Gacko commented Apr 1, 2023

btw: I'll implement vendir once we aligned all the stuff from upstream, even the breaking ones, and released a new major version.

@Gacko Gacko force-pushed the feature/upstream-alignment branch from d706df0 to abd1894 Compare April 1, 2023 18:30
@Gacko
Copy link
Member Author

Gacko commented Apr 1, 2023

Wasn't able to test it on Azure due to cluster creation issues.

@Gacko Gacko merged commit 91bc393 into main Apr 1, 2023
@Gacko Gacko deleted the feature/upstream-alignment branch April 1, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants