Service: Remove controller.service.suffix & controller.service.internal.suffix.

[Gacko]

Tests on workload clusters (not always required)

For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:

Test / Provider	AWS	Azure	KVM
Upgrade from previous version	✓	✓
Existing Ingress resources are reconciled correctly	✓	✓
Fresh install	✓	✓
Fresh Ingress resources are reconciled correctly	✓	✓

Testing was done using hello-world-app.

Hint for KVM:

kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:127.0.0.1:8080" "http://$ingress_domain" -v

[Gacko]

If the Service's name changes due to removing either controller.service.suffix or controller.service.internal.suffix, Helm will create a new service and remove the old one. In case of LoadBalancer services, this might take a few moments. Anyway: Things break, there will be an outage.

This is why we're going to release this in a major release and suggest to first deploy a new release and then remove the old one after ensuring the former one is working & DNS got updated.

[ubergesundheit]

🤞