Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment/DaemonSet: Remove cluster-autoscaler.kubernetes.io/safe-to-evict annotation. #449

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Apr 7, 2023

Tests on workload clusters (not always required)

For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:

Test / Provider AWS Azure KVM
Upgrade from previous version
Existing Ingress resources are reconciled correctly
Fresh install
Fresh Ingress resources are reconciled correctly

Testing was done using hello-world-app.

Hint for KVM:

kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:127.0.0.1:8080" "http://$ingress_domain" -v

@Gacko Gacko marked this pull request as ready for review April 7, 2023 09:56
@Gacko Gacko requested a review from a team as a code owner April 7, 2023 09:56
@Gacko Gacko force-pushed the feature/remove-safe-to-evict branch from 1f2dcb3 to 09dfe04 Compare April 11, 2023 14:41
@Gacko Gacko merged commit c2b8901 into main Apr 12, 2023
@Gacko Gacko deleted the feature/remove-safe-to-evict branch April 12, 2023 08:58
@Gacko Gacko restored the feature/remove-safe-to-evict branch April 12, 2023 14:18
@Gacko Gacko deleted the feature/remove-safe-to-evict branch April 12, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants